-
Notifications
You must be signed in to change notification settings - Fork 565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Polish Dropship Weapons UI #5298
Conversation
This comment was marked as off-topic.
This comment was marked as off-topic.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - is that TM worth?
I was told to comment on the actual PR to report bugs/issues. Also, when using medevac, you can click Equip to go back to the main selection of installed modules/guns, but when you do fulton the equip button is not there, just minor QoL, but makes it so you have to full back then go into equip again. |
Thanks for the report. All that should be addressed now too. I'll note however the medevac interaction will just move the dropship over the stretcher and set the camera; hoisting still requires manual interaction. |
…till not perfect...)
About the pull request
This PR is a follow up to #4812 polishing minor issues that were discovered but not addressed in that PR.
Partiallyfixed camera view for sentry(map size doesn't always get set correctly some reason)/client/proc/clear_map
based on Harddeletes: Accident edition tgstation/tgstation#61562Explain why it's good for the game
Fixes issues such as (but not limited to):
Testing Photographs and Procedure
Screenshots & Videos
Changelog
🆑 Drathek
ui: Polished various aspects of the new dropship weapons UI
fix: Fixed CAS direct firing
fix: Fixed Medevac buttons not moving the dropship (still currently requires manual winch)
fix: Fixed camera_manager resizing the view incorrectly because of overlay_lighting
refactor: Ported some hard delete fixes for maps.
/:cl: